Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Timestamp unit with time and not date #54097

Merged
merged 2 commits into from
Jul 13, 2023
Merged

BUG: Timestamp unit with time and not date #54097

merged 2 commits into from
Jul 13, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel
Copy link
Member Author

@MarcoGorelli this was the root cause of something you were looking at a few weeks ago, but i dont remember what the motivating issue was

MarcoGorelli
MarcoGorelli approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

I don't remember raising this, but looks good

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Jul 13, 2023
@MarcoGorelli MarcoGorelli added the Datetime Datetime data dtype label Jul 13, 2023
@MarcoGorelli MarcoGorelli merged commit 7672459 into pandas-dev:main Jul 13, 2023
40 checks passed
@jbrockmendel jbrockmendel deleted the bug-time-unit branch July 13, 2023 13:52
@jbrockmendel jbrockmendel mentioned this pull request Jul 18, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbrockmendel @MarcoGorelli