#50990 Increase to_dict('list') performance #54824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 30, 2023
mroeschke
reviewed
Aug 30, 2023
mroeschke
reviewed
Aug 30, 2023
mroeschke
reviewed
Aug 30, 2023
mroeschke
reviewed
Aug 30, 2023
mroeschke
reviewed
Aug 31, 2023
pandas/core/methods/to_dict.py
Outdated
| ) | ||
| for i, (k, v) in enumerate(df.items()) | ||
| for i, col in enumerate(df.columns) |
There was a problem hiding this comment.
Could you add a test where to_dict("list") is called on a DataFrame with duplicate column labels?
There was a problem hiding this comment.
thanks for the catch, didin think about it
mroeschke
approved these changes
Sep 1, 2023
|
Thanks @taytzehao |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
* autoformat * autoformat * whatsnew * reformat * rm values * to_numpy() * to_numpy() * rm newline * .items * unit test * comment
5 tasks
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.1.0.rstfile if fixing a bug or adding a new feature.25.8±2ms 1.61±0.4ms 0.06 frame_methods.ToDict.time_to_dict_datetimelike('list')