Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: lexsort_indexer (MultiIndex / multi-column sorting) #54835

Merged
merged 7 commits into from Aug 30, 2023

Conversation

lukemanley
Copy link
Member

@lukemanley lukemanley commented Aug 29, 2023

Improves performance for MultiIndex and multi-column sorting.

frame_methods.SortMultiKey:

       before           after         ratio
-      51.1±0.7ms       45.0±0.5ms     0.88  frame_methods.SortMultiKey.time_sort_values
-        11.6±1ms       6.38±0.3ms     0.55  frame_methods.SortMultiKey.time_sort_index

multiindex_object.SetOperations:

       before           after         ratio
-        29.4±2ms       19.5±0.2ms     0.66  multiindex_object.SetOperations.time_operation('monotonic', 'ea_int', 'intersection', None)
-        42.4±2ms         26.8±2ms     0.63  multiindex_object.SetOperations.time_operation('non_monotonic', 'int', 'intersection', None)
-        30.8±1ms         19.4±2ms     0.63  multiindex_object.SetOperations.time_operation('non_monotonic', 'int', 'union', None)
-        32.4±2ms         20.2±2ms     0.63  multiindex_object.SetOperations.time_operation('non_monotonic', 'ea_int', 'union', None)
-        30.5±1ms       18.7±0.4ms     0.61  multiindex_object.SetOperations.time_operation('monotonic', 'int', 'intersection', None)
-        34.8±4ms         19.4±2ms     0.56  multiindex_object.SetOperations.time_operation('non_monotonic', 'datetime', 'union', None)
-        25.4±3ms       14.1±0.7ms     0.56  multiindex_object.SetOperations.time_operation('monotonic', 'datetime', 'union', None)
-        33.7±1ms         17.2±1ms     0.51  multiindex_object.SetOperations.time_operation('non_monotonic', 'string', 'union', None)
-        35.2±3ms       16.5±0.8ms     0.47  multiindex_object.SetOperations.time_operation('monotonic', 'string', 'union', None)
-        41.3±1ms         18.4±2ms     0.45  multiindex_object.SetOperations.time_operation('non_monotonic', 'string', 'intersection', None)
-        40.8±2ms       18.1±0.6ms     0.44  multiindex_object.SetOperations.time_operation('non_monotonic', 'datetime', 'intersection', None)
-        48.6±4ms         19.8±2ms     0.41  multiindex_object.SetOperations.time_operation('non_monotonic', 'ea_int', 'intersection', None)
-        45.1±5ms         17.9±2ms     0.40  multiindex_object.SetOperations.time_operation('monotonic', 'string', 'intersection', None)

multiindex_object.Difference:

       before           after         ratio
-      6.55±0.5ms       3.88±0.2ms     0.59  multiindex_object.Difference.time_difference('string')
-      5.42±0.7ms       3.10±0.3ms     0.57  multiindex_object.Difference.time_difference('ea_int')

@lukemanley lukemanley added Performance Memory or execution speed performance MultiIndex labels Aug 29, 2023
@lukemanley lukemanley added this to the 2.2 milestone Aug 29, 2023
# "List[Union[ExtensionArray, ndarray[Any, Any], Index, Series]]", variable
# has type "Union[List[Union[ExtensionArray, ndarray[Any, Any]]], List[Series]]")
keys = [ensure_key_mapped(k, key) for k in keys] # type: ignore[assignment]
keys = [ensure_key_mapped(k, key) for k in keys]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could we make this a generator?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks

@mroeschke mroeschke merged commit 609c3b7 into pandas-dev:main Aug 30, 2023
38 checks passed
@mroeschke
Copy link
Member

Nice! Thanks @lukemanley

@lukemanley lukemanley deleted the lexsort-indexer branch September 6, 2023 00:53
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
…#54835)

* lexsort_indexer perf

* whatsnew

* mypy

* mypy

* use generator

* mypy
@lukemanley lukemanley mentioned this pull request Oct 4, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MultiIndex Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants