Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: ArrayManager #55043

Closed
rhshadrach opened this issue Sep 7, 2023 · 4 comments · Fixed by #55044
Closed

DEPR: ArrayManager #55043

rhshadrach opened this issue Sep 7, 2023 · 4 comments · Fixed by #55044
Assignees
Labels
ArrayManager Deprecate Functionality to remove in pandas
Milestone

Comments

@rhshadrach
Copy link
Member

Discussed in Basel, I believe there is a consensus to deprecate the ArrayManager.

cc @pandas-dev/pandas-core

@rhshadrach rhshadrach added Deprecate Functionality to remove in pandas ArrayManager labels Sep 7, 2023
@rhshadrach rhshadrach self-assigned this Sep 7, 2023
@rhshadrach rhshadrach added this to the 2.2 milestone Sep 7, 2023
@rhshadrach rhshadrach mentioned this issue Sep 7, 2023
5 tasks
@Dr-Irv
Copy link
Contributor

Dr-Irv commented Sep 11, 2023

Discussed in Basel, I believe there is a consensus to deprecate the ArrayManager.

Can you summarize that discussion here for those of us who weren't in Basel?

@rhshadrach
Copy link
Member Author

rhshadrach commented Sep 12, 2023

I believe the main points are:

  • We do not see ArrayManager and BlockManager existing side-by-side in perpetuity. We need to choose one or the other.
  • Support for zero-copy to NumPy requires blocks, and is important to packages like scikit-learn
  • ArrayManager is not tested on the CI and is currently failing (I'm seeing 1038 failing)
  • We would like to instead pursue creating 2D EAs

@topper-123
Copy link
Contributor

I agree with the points you made, especially that we should pick one or the other and I'm fine with BlockManager being the one used going forward.

I'm +1 on this.

@simonjayhawkins
Copy link
Member

in the roadmap we have a section on "Block manager rewrite".

Now the roadmap pre dates the PDEP process and in the section "Roadmap points pending a PDEP" we have

pandas is in the process of moving roadmap points to PDEPs (implemented in August 2022). During the transition, some roadmap points will exist as PDEPs, while others will exist as sections below.

Now that this issue is closed do we need to make any changes to the roadmap on the web page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArrayManager Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants