Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Add is_hashable_non_slice #55152

Open
lithomas1 opened this issue Sep 15, 2023 · 1 comment
Open

CLN: Add is_hashable_non_slice #55152

lithomas1 opened this issue Sep 15, 2023 · 1 comment
Labels
Clean

Comments

@lithomas1
Copy link
Member

lithomas1 commented Sep 15, 2023 •
edited

very late review comment: would it make sense to make is_hashable_non_slice or something? it wouldn't surprise me if many places that use is_hashable current assume non-slice but didn't get updated by this PR

Originally posted by @jbrockmendel in #53743 (comment)
@lithomas1 lithomas1 mentioned this issue Sep 15, 2023
Merged
5 tasks
@rhshadrach
Copy link
Member

Maybe an allow_slice argument to is_hashable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhshadrach @lithomas1