Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Index.insert raising when inserting None into new string dtype #55365

Merged
merged 6 commits into from Oct 3, 2023
Merged

BUG: Index.insert raising when inserting None into new string dtype #55365

merged 6 commits into from Oct 3, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Oct 3, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added this to the 2.1.2 milestone Oct 3, 2023
mroeschke
mroeschke reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise LGTM

@mroeschke mroeschke added Strings String extension data type and string data Arrow pyarrow functionality Index Related to the Index class or subclasses labels Oct 3, 2023
@phofl @mroeschke
Update doc/source/whatsnew/v2.1.2.rst
9a7730e 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@phofl phofl merged commit 8664572 into pandas-dev:main Oct 3, 2023
38 of 39 checks passed
@phofl phofl deleted the index_insert branch October 3, 2023 20:02
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 3, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 8664572fe63dbcb865588d9d564b49a572c3351e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55365: BUG: Index.insert raising when inserting None into new string dtype'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55365-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #55365 on branch 2.1.x (BUG: Index.insert raising when inserting None into new string dtype)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

phofl added a commit to phofl/pandas that referenced this pull request Oct 3, 2023
@phofl
BUG: Index.insert raising when inserting None into new string dtype (p…
3c7726c 
…andas-dev#55365)

(cherry picked from commit 8664572)
@phofl phofl mentioned this pull request Oct 3, 2023
Merged
mroeschke pushed a commit that referenced this pull request Oct 3, 2023
@phofl
Backport PR #55365 on branch 2.1.x (BUG: Index.insert raising when in…
2201408 
…serting None into new string dtype) (#55383)

BUG: Index.insert raising when inserting None into new string dtype (#55365)

(cherry picked from commit 8664572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

Assignees
No one assigned
Labels
Arrow pyarrow functionality Index Related to the Index class or subclasses Strings String extension data type and string data
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phofl @mroeschke