Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add SAS7BDATReader and XportReader to pandas/api/typing/__init__.py #55689

Closed
1 of 3 tasks
mroeschke opened this issue Oct 25, 2023 · 1 comment · Fixed by #58349
Closed
1 of 3 tasks

ENH: Add SAS7BDATReader and XportReader to pandas/api/typing/__init__.py #55689

mroeschke opened this issue Oct 25, 2023 · 1 comment · Fixed by #58349
Labels
Enhancement IO SAS SAS: read_sas Typing type annotations, mypy/pyright type checking

Comments

@mroeschke
Copy link
Member

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

These classes can be returned by read_sas(..., iterator=True/chunksize=...)

Feature Description

Adding from pandas.io.sas.sas_xport import XportReader and from pandas.io.sas.sas7bdat import SAS7BDATReader to pandas/api/typing/__init__.py

Alternative Solutions

None

Additional Context

No response

@mroeschke mroeschke added Enhancement IO SAS SAS: read_sas Typing type annotations, mypy/pyright type checking labels Oct 25, 2023
@twoertwein
Copy link
Member

It could(?) be sufficient to export the abstract base class.

class ReaderBase(ABC):

The concrete classes should probably(?) contain only implementation details.

If we go that route, we probably should let ReaderBase inherit from Iterator instead of the child classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement IO SAS SAS: read_sas Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants