Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Index.isin raising for arrow strings and null set #55821

Merged
merged 1 commit into from Nov 4, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 4, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added the Arrow pyarrow functionality label Nov 4, 2023
@mroeschke mroeschke added this to the 2.1.3 milestone Nov 4, 2023
@mroeschke mroeschke merged commit 365448d into pandas-dev:main Nov 4, 2023
43 of 44 checks passed
@mroeschke
Copy link
Member

Thanks @phofl

Copy link

lumberbot-app bot commented Nov 4, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 365448dc665f6d49f3d3071a6c3a04aaccacb3d2
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55821: BUG: Index.isin raising for arrow strings and null set'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55821-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #55821 on branch 2.1.x (BUG: Index.isin raising for arrow strings and null set)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants