PERF: assert_frame_equal / assert_series_equal #55971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Testing
4 tasks
pandas/_testing/asserters.py
Outdated
| @@ -328,7 +319,7 @@ def _get_ilevel_values(index, level): | |||
| diff = np.sum(mismatch.astype(int)) * 100.0 / len(left) | |||
| msg = f"{obj} values are different ({np.round(diff, 5)} %)" | |||
| raise_assert_detail(obj, msg, left, right) | |||
| else: | |||
| elif not left.equals(right): | |||
There was a problem hiding this comment.
do we know that .equals is the correct amount of strict?
There was a problem hiding this comment.
I think so, but after reviewing again I've reverted this line in favor of a lower level change to _array_equivalent_object.
This has the benefit of improving performance for more cases, e.g. not just the index values but in this case the series values:
import pandas as pd
N = 100_000
values = pd._testing.makeStringIndex(N).values
ser1 = pd.Series(values.copy())
ser2 = pd.Series(values.copy())
%timeit pd.testing.assert_series_equal(ser1, ser2)
1.92 s ± 56.1 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
22.3 ms ± 4.18 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)
mroeschke
reviewed
Nov 16, 2023
mroeschke
approved these changes
Nov 17, 2023
|
Thanks @lukemanley |
| return lib.array_equivalent_object(ensure_object(left), ensure_object(right)) | ||
|
|
||
| for left_value, right_value in zip(left, right): | ||
| left = ensure_object(left) |
There was a problem hiding this comment.
can we get here in cases that are not already object? seems like if that happens then something has gone wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.2.0.rstfile if fixing a bug or adding a new feature.Follow-up to #55949 addressing some of @jbrockmendel's comments and also expanding to non-multiindex cases: