BUG: ne comparison returns False for NA and other value #56123
Conversation
phofl
added
Strings
| @@ -663,7 +664,10 @@ def _convert_int_dtype(self, result): | |||
|
|
|||
| def _cmp_method(self, other, op): | |||
| result = super()._cmp_method(other, op) | |||
There was a problem hiding this comment.
Shouldn't this be fixed in the ArrowExtensionArray._cmp_method?
There was a problem hiding this comment.
No, the arrow dtypes will return an arrow array with bool dtype that has NA values in those places, which is correct, this fix is to emulate object dtype
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
Thanks @phofl |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…6123) * BUG: ne comparison returns False for NA and other value * Fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit c369d93)
…for NA and other value) (#56382)
returning True here makes more sense than False for !=