BUG: fix subclass metadata preservation in groupby column selection #56761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Groupby
Regression
phofl
approved these changes
Jan 7, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 7, 2024
… in groupby column selection
2 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small regression that was introduced with #51090 (in pandas 2.0): before that PR, the column subselection in the groupby code was done with a standard
__getitem__call, while the PR introduced an optimized helper_getitem_nocopyto avoid the copy that a standard__getitem__does. However, that new helper forgot to add a__finalize__call after_constructorfrom a manager.The reason we noticed this in geopandas (geopandas/geopandas#3130) was to update our tests for the
applydeprecation to include group columns (for which one alternative is to specifically select the non-group columns, but so that didn't work with recent pandas versions)