Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: test_setitem_integer_with_missing_raises contains duplicate parametrization #56727

Open
mroeschke opened this issue Jan 4, 2024 · 2 comments · May be fixed by #57629
Open

TST: test_setitem_integer_with_missing_raises contains duplicate parametrization #56727

mroeschke opened this issue Jan 4, 2024 · 2 comments · May be fixed by #57629
Assignees
@lopof
Labels
Bug ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite

Comments

@mroeschke
Copy link
Member

pandas/pandas/tests/extension/base/setitem.py

Lines 211 to 216 in c4b6bed

(pd.array([0, 1, 2, pd.NA], dtype="Int64"), False),
(pd.array([0, 1, 2, pd.NA], dtype="Int64"), False),
],
ids=["list-False", "list-True", "integer-array-False", "integer-array-True"],
)
def test_setitem_integer_with_missing_raises(self, data, idx, box_in_series):

One of these parametrizations should probably be (pd.array([0, 1, 2, pd.NA], dtype="Int64"), True), but that fails several tests that inherit this test. The task is to investigate whether the failure is expected or OK to xfail
@mroeschke mroeschke added Bug Testing pandas testing functions or related to the test suite ExtensionArray Extending pandas with custom dtypes or arrays. labels Jan 4, 2024
@mroeschke mroeschke mentioned this issue Jan 4, 2024
Merged
@pmhatre1
Copy link
Contributor

pmhatre1 commented Jan 6, 2024

pytest pandas/tests/extension/base/setitem.py I was trying this command to debug this but no tests were run. Any command to run it in command line?

@lopof
Copy link
Contributor

lopof commented Jan 15, 2024

take

@lopof lopof mentioned this issue Jan 15, 2024
Closed
4 tasks
@lopof lopof linked a pull request Feb 26, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lopof lopof

Labels
Bug ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
3 participants
@mroeschke @lopof @pmhatre1