Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: groupby().groups with multiple group keys always treats sort as True #56966

Closed
2 of 3 tasks
mvashishtha opened this issue Jan 19, 2024 · 3 comments · Fixed by #55738
Closed
2 of 3 tasks

BUG: groupby().groups with multiple group keys always treats sort as True #56966

mvashishtha opened this issue Jan 19, 2024 · 3 comments · Fixed by #55738
Assignees
Labels
Bug Groupby Sorting e.g. sort_index, sort_values

Comments

@mvashishtha
Copy link

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

import pandas as pd

df = pd.DataFrame([[2, 1], [0, 3]])

print(df.groupby([0, 1], sort=False).groups)
print(df.groupby([0, 1], sort=True).groups)
# can see that order should be different for aggregations like sum()
print(df.groupby([0, 1], sort=False).sum())
print(df.groupby([0, 1], sort=True).sum())

Issue Description

groupby().groups with multiple group keys always treats sort as True

Expected Behavior

Per the documentation here, when sort=False,

the groups will appear in the same order as they did in the original DataFrame.

Installed Versions

INSTALLED VERSIONS

commit : a671b5a
python : 3.9.18.final.0
python-bits : 64
OS : Darwin
OS-release : 23.2.0
Version : Darwin Kernel Version 23.2.0: Wed Nov 15 21:55:06 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6020
machine : arm64
processor : arm
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8

pandas : 2.1.4
numpy : 1.26.3
pytz : 2023.3.post1
dateutil : 2.8.2
setuptools : 68.2.2
pip : 23.3.1
Cython : None
pytest : None
hypothesis : None
sphinx : None
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : None
IPython : 8.18.1
pandas_datareader : None
bs4 : None
bottleneck : None
dataframe-api-compat: None
fastparquet : None
fsspec : None
gcsfs : None
matplotlib : None
numba : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : None
pyreadstat : None
pyxlsb : None
s3fs : None
scipy : None
sqlalchemy : None
tables : None
tabulate : None
xarray : None
xlrd : None
zstandard : None
tzdata : 2023.4
qtpy : None
pyqt5 : None

@mvashishtha mvashishtha added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 19, 2024
@rhshadrach
Copy link
Member

Thanks for the report. Closing as a duplicate of #56851.

@rhshadrach rhshadrach added Groupby Sorting e.g. sort_index, sort_values Duplicate Report Duplicate issue or pull request and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 19, 2024
@rhshadrach
Copy link
Member

Actually - this is a bit different. Reopening.

@rhshadrach rhshadrach reopened this Jan 19, 2024
@rhshadrach rhshadrach removed the Duplicate Report Duplicate issue or pull request label Jan 19, 2024
@rhshadrach
Copy link
Member

But this would also be closed by #55738! Tests need to be added to that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Groupby Sorting e.g. sort_index, sort_values
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants