Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Stable sort on DatetimeIndex is not stable #57151

Closed
2 of 3 tasks
robert-schmidtke opened this issue Jan 30, 2024 · 1 comment · Fixed by #57169
Closed
2 of 3 tasks

BUG: Stable sort on DatetimeIndex is not stable #57151

robert-schmidtke opened this issue Jan 30, 2024 · 1 comment · Fixed by #57169
Labels
Bug Index Related to the Index class or subclasses Regression Functionality that used to work in a prior pandas version Sorting e.g. sort_index, sort_values
Milestone

Comments

@robert-schmidtke
Copy link
Contributor

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

import pandas as pd

df = pd.DataFrame(
    data=[
        (pd.Timestamp("2024-01-30 13:00:00"), 13.0),
        (pd.Timestamp("2024-01-30 13:00:00"), 13.1),
        (pd.Timestamp("2024-01-30 12:00:00"), 12.0),
        (pd.Timestamp("2024-01-30 12:00:00"), 12.1),
    ],
    columns=["dt", "value"],
).set_index(["dt"])

df.sort_index(level="dt", kind="stable")
#                      value
# dt
# 2024-01-30 12:00:00   12.1
# 2024-01-30 12:00:00   12.0
# 2024-01-30 13:00:00   13.1
# 2024-01-30 13:00:00   13.0

Issue Description

Sorting on a timestamp index is not stable, even when using kind="stable".

Expected Behavior

Sorting to be stable, as with pandas=2.1.4:

import pandas as pd

df = pd.DataFrame(
    data=[
        (pd.Timestamp("2024-01-30 13:00:00"), 13.0),
        (pd.Timestamp("2024-01-30 13:00:00"), 13.1),
        (pd.Timestamp("2024-01-30 12:00:00"), 12.0),
        (pd.Timestamp("2024-01-30 12:00:00"), 12.1),
    ],
    columns=["dt", "value"],
).set_index(["dt"])

df.sort_index(level="dt", kind="stable")
#                      value
# dt
# 2024-01-30 12:00:00   12.0
# 2024-01-30 12:00:00   12.1
# 2024-01-30 13:00:00   13.0
# 2024-01-30 13:00:00   13.1

Installed Versions

INSTALLED VERSIONS

commit : f538741
python : 3.11.7.final.0
python-bits : 64
OS : Linux
OS-release : 5.15.133.1-microsoft-standard-WSL2
Version : #1 SMP Thu Oct 5 21:02:42 UTC 2023
machine : x86_64
processor : x86_64
byteorder : little
LC_ALL : None
LANG : C.UTF-8
LOCALE : en_US.UTF-8

pandas : 2.2.0
numpy : 1.26.3
pytz : 2023.4
dateutil : 2.8.2
setuptools : 69.0.3
pip : 23.3.2
Cython : None
pytest : None
hypothesis : None
sphinx : None
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : None
IPython : None
pandas_datareader : None
adbc-driver-postgresql: None
adbc-driver-sqlite : None
bs4 : None
bottleneck : None
dataframe-api-compat : None
fastparquet : None
fsspec : None
gcsfs : None
matplotlib : None
numba : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : 14.0.2
pyreadstat : None
python-calamine : None
pyxlsb : None
s3fs : None
scipy : None
sqlalchemy : None
tables : None
tabulate : None
xarray : None
xlrd : None
zstandard : None
tzdata : 2023.4
qtpy : None
pyqt5 : None

@robert-schmidtke robert-schmidtke added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 30, 2024
@rhshadrach
Copy link
Member

Thanks for the report! Result of a git bisect:

commit b6834f8b93d20c99cf3f1c527ba4ba2a462c69d9
Author: Luke Manley
Date:   Thu Nov 23 14:45:42 2023 -0500

    PERF: Index.sort_values for already sorted index (#56128)

cc @lukemanley

@rhshadrach rhshadrach added Regression Functionality that used to work in a prior pandas version Index Related to the Index class or subclasses Sorting e.g. sort_index, sort_values and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 31, 2024
@rhshadrach rhshadrach added this to the 2.2.1 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Index Related to the Index class or subclasses Regression Functionality that used to work in a prior pandas version Sorting e.g. sort_index, sort_values
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants