Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: only keep conda cache for one day #57747

Closed

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Mar 6, 2024

Our conda envs are being cached, but that also means that for the dev builds (eg numpy nightly, pyarrow nightly), you don't actually get the latest version, depending on whether some other change happened in the CI setup that would invalidate the cache.

Maybe ideally we do this only for those builds that test for other dev packages?

From https://github.com/mamba-org/setup-micromamba?tab=readme-ov-file#caching
Related issue: mamba-org/setup-micromamba#50

@jorisvandenbossche jorisvandenbossche added the CI Continuous Integration label Mar 6, 2024
@mroeschke
Copy link
Member

I would also support invalidating all caches daily (the pre-commit caches I think are the only ones that are not affected by changing the conda key). You could update this workflow's cron to daily (and rename the file) https://github.com/pandas-dev/pandas/blob/main/.github/workflows/cache-cleanup-weekly.yml

Copy link
Contributor

github-actions bot commented Apr 6, 2024

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@mroeschke
Copy link
Member

This got implemented in #58710 (thanks for the inspiration!) so closing

@mroeschke mroeschke closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants