Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential regression induced by PR "PERF: Categorical(range).categories returns RangeIndex instead of Index" #57829

Closed
DeaMariaLeon opened this issue Mar 13, 2024 · 1 comment
Labels
MultiIndex Performance Memory or execution speed performance

Comments

@DeaMariaLeon
Copy link
Member

PR #57787

If this is expected please ignore the issue.

The regressions seem to be here:

indexing.MultiIndexing.time_xs_full_key (Python) with unique_levels=True
indexing.MultiIndexing.time_loc_all_scalars (Python) with unique_levels=True

@mroeschke

Screenshot 2024-03-13 at 12 50 02 Screenshot 2024-03-13 at 12 52 54
@mroeschke
Copy link
Member

Thanks for the report. After profiling for a bit, it looks like there's an slight increase when creating the MulitiIndex._engine, but given that this is cached I am not too concerned given the memory reduction of the Index level class.

@mroeschke mroeschke added Performance Memory or execution speed performance MultiIndex labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MultiIndex Performance Memory or execution speed performance
Projects
None yet
Development

No branches or pull requests

2 participants