Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential regression induced by "CLN: Enforce deprecation of argmin/max and idxmin/max with NA values" #58013

Closed
DeaMariaLeon opened this issue Mar 26, 2024 · 3 comments
Labels
Benchmark Performance (ASV) benchmarks Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Performance Memory or execution speed performance Reduction Operations sum, mean, min, max, etc. Regression Functionality that used to work in a prior pandas version

Comments

@DeaMariaLeon
Copy link
Member

PR #57971

If it is expected please ignore this issue.

"series_methods.NanOps.time_func (Python) with N=1000, dtype='int64', func='argmax'": "http://57.128.112.95:5000/compare/benchmarks/0660238e608270fe8000d90917fab443...066023bb74387b2880001e8c3a13bc9a",
"series_methods.NanOps.time_func (Python) with N=1000, dtype='int32', func='argmax'": "http://57.128.112.95:5000/compare/benchmarks/0660238e5f92703b8000518426c1e358...066023bb739a770480009c84952aeeef",
"series_methods.NanOps.time_func (Python) with N=1000, dtype='float64', func='argmax'": "http://57.128.112.95:5000/compare/benchmarks/0660238e6123788c800045f9fafc0110...066023bb74d0713e8000b7a515b8b450",
"series_methods.NanOps.time_func (Python) with N=1000000, dtype='float64', func='argmax'": "http://57.128.112.95:5000/compare/benchmarks/0660238e642e791e80009e362f432db3...066023bb77a3764180003374cf6f549e",
"series_methods.NanOps.time_func (Python) with N=1000000, dtype='int32', func='argmax'": "http://57.128.112.95:5000/compare/benchmarks/0660238e62897b5a8000f233376be753...066023bb7642748e800066e39b4e1ef1",
"series_methods.NanOps.time_func (Python) with N=1000000, dtype='int8', func='argmax'": "http://57.128.112.95:5000/compare/benchmarks/0660238e61dd7d9d80001bbda6f52684...066023bb759c744480000ea47833c954",
"series_methods.NanOps.time_func (Python) with N=1000, dtype='int8', func='argmax'": "http://57.128.112.95:5000/compare/benchmarks/0660238e5ee8721780008aed6e250c64...066023bb72f377158000ee04eb8137ee"

@rhshadrach

Screenshot 2024-03-26 at 16 03 17

@DeaMariaLeon DeaMariaLeon added the Benchmark Performance (ASV) benchmarks label Mar 26, 2024
@rhshadrach rhshadrach added Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version Reduction Operations sum, mean, min, max, etc. Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Mar 26, 2024
@rhshadrach
Copy link
Member

rhshadrach commented Mar 26, 2024

Thanks @DeaMariaLeon - I expect #58019 will close this, but do we want to leave it open until it can be confirmed? I think that PR would need to be merged first, right?

@DeaMariaLeon
Copy link
Member Author

I think so @rhshadrach - that's the way the other devs have been doing it.

@DeaMariaLeon
Copy link
Member Author

Thanks @rhshadrach :-)
(Verified the other links too.)

Screenshot 2024-04-04 at 17 09 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Performance Memory or execution speed performance Reduction Operations sum, mean, min, max, etc. Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

No branches or pull requests

2 participants