Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: fix compatibility with beautifulsoup4 4.13.0b2 #58100

Merged
merged 1 commit into from Apr 1, 2024
Merged

MNT: fix compatibility with beautifulsoup4 4.13.0b2 #58100

merged 1 commit into from Apr 1, 2024

Conversation

neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Apr 1, 2024 •
edited

Closes #58086

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@neutrinoceros
Copy link
Contributor Author

I'm not sure this change warrants a changelog entry, but I'll happily add one upon request.

@neutrinoceros neutrinoceros mentioned this pull request Apr 1, 2024
Closed
@neutrinoceros neutrinoceros marked this pull request as ready for review April 1, 2024 12:49
@mroeschke mroeschke added IO HTML read_html, to_html, Styler.apply, Styler.applymap Dependencies Required and optional dependencies labels Apr 1, 2024
@mroeschke mroeschke added this to the 3.0 milestone Apr 1, 2024
@mroeschke mroeschke merged commit e3f9298 into pandas-dev:main Apr 1, 2024
52 of 54 checks passed
@mroeschke
Copy link
Member

Thanks @neutrinoceros (doesn't need a changelog entry)

@neutrinoceros neutrinoceros deleted the mnt/compat_bs4 branch April 1, 2024 17:17
diogomsmiranda pushed a commit to diogomsmiranda/pandas that referenced this pull request Apr 1, 2024
@neutrinoceros @diogomsmiranda
MNT: fix compatibility with beautifulsoup4 4.13.0b2 (pandas-dev#58100)
97ebdc0
@neutrinoceros
Copy link
Contributor Author

Thanks for merging ! Would it be alright to backport this ?

@mroeschke
Copy link
Member

Sure I supposed that would be OK

@mroeschke
Copy link
Member

@meeseeksdev backport 2.2.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Apr 3, 2024
@neutrinoceros @meeseeksmachine
Backport PR pandas-dev#58100: MNT: fix compatibility with beautifulso…
cfe7f7b 
…up4 4.13.0b2
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 3, 2024
Merged
mroeschke pushed a commit that referenced this pull request Apr 3, 2024
@meeseeksmachine @neutrinoceros
Backport PR #58100 on branch 2.2.x (MNT: fix compatibility with beaut…
b56842d 
…ifulsoup4 4.13.0b2) (#58137)

Backport PR #58100: MNT: fix compatibility with beautifulsoup4 4.13.0b2

Co-authored-by: Clément Robert <cr52@protonmail.com>
@neutrinoceros
Copy link
Contributor Author

thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies IO HTML read_html, to_html, Styler.apply, Styler.applymap
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: beautifulsoup4 breaks pandas.read_html
2 participants
@neutrinoceros @mroeschke