Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Documentation side navigation bar loses scroll position on option selection #58177

Open
1 task done
Aloqeely opened this issue Apr 8, 2024 · 3 comments
Open
1 task done
Labels

Comments

@Aloqeely
Copy link
Member

Aloqeely commented Apr 8, 2024

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

Any page with the side navigation bar (e.g. https://pandas.pydata.org/docs/reference/index.html)

Documentation problem

When clicking on an option in the side navigation bar, the page content updates and the scroll position in the sidebar jumps to the top.

Suggested fix for documentation

The scroll position in the sidebar should remain unchanged after selecting an option.

@Aloqeely Aloqeely added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 8, 2024
@rhshadrach
Copy link
Member

Is this feasible to change? We're loading a new page, not updating an iframe or something like that.

cc @datapythonista

@rhshadrach rhshadrach added Needs Discussion Requires discussion from core team before further action and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 8, 2024
@Aloqeely
Copy link
Member Author

I don't know much about sphinx or web development, but I think this should be doable since it doesn't happen in other libs' docs (e.g. numpy)

It's really frustrating when you're trying to view subsequent options in the docs.

@rhshadrach
Copy link
Member

it doesn't happen in other libs' docs (e.g. numpy)

Thanks! NumPy is also using the pydata_sphinx_theme, so it does look hopeful that this can be resolved. Further investigations and PRs to fix are welcome!

@rhshadrach rhshadrach removed the Needs Discussion Requires discussion from core team before further action label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants