Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential regression induced by commit eb55bca #58286

Closed
14 tasks
rhshadrach opened this issue Apr 17, 2024 · 2 comments
Closed
14 tasks

Potential regression induced by commit eb55bca #58286

rhshadrach opened this issue Apr 17, 2024 · 2 comments
Labels
Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version Timedelta Timedelta data type
Milestone

Comments

@rhshadrach
Copy link
Member

PR #55999 may have induced a performance regression. If it was a necessary behavior change, this may have been expected and everything is okay.

Please check the links below. If any ASVs are parameterized, the combinations of parameters that a regression has been detected for appear as subbullets.

Subsequent benchmarks may have skipped some commits. The link below lists the commits that are between the two benchmark runs where the regression was identified.

Commit Range

cc @WillAyd

@rhshadrach rhshadrach added Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version Timedelta Timedelta data type labels Apr 17, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Apr 17, 2024
@WillAyd
Copy link
Member

WillAyd commented Apr 17, 2024

Awesome thanks. This was also discussed in #57951 - I believe @dontgoto has been taking a look

@rhshadrach
Copy link
Member Author

Doh - closing as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version Timedelta Timedelta data type
Projects
None yet
Development

No branches or pull requests

2 participants