Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential regression induced by commit 1ee5832 #58288

Closed
1 task
rhshadrach opened this issue Apr 17, 2024 · 2 comments
Closed
1 task

Potential regression induced by commit 1ee5832 #58288

rhshadrach opened this issue Apr 17, 2024 · 2 comments
Labels
IO Data IO issues that don't fit into a more specific label Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Milestone

Comments

@rhshadrach
Copy link
Member

PR #58118 may have induced a performance regression. If it was a necessary behavior change, this may have been expected and everything is okay.

Please check the links below. If any ASVs are parameterized, the combinations of parameters that a regression has been detected for appear as subbullets.

Subsequent benchmarks may have skipped some commits. The link below lists the commits that are between the two benchmark runs where the regression was identified.

Commit Range

cc @mroeschke

@rhshadrach rhshadrach added IO Data IO issues that don't fit into a more specific label Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version labels Apr 17, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Apr 17, 2024
@rhshadrach
Copy link
Member Author

Likely a case where we're okay with the tradeoff, but wanted to make sure (haven't looked into the details).

@mroeschke
Copy link
Member

I think #58150 also already highlighted this potential issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Data IO issues that don't fit into a more specific label Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

No branches or pull requests

2 participants