Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Docstrings missing from .py files in Sphinxext docs folder #58812

Open
1 task done
shindelr opened this issue May 22, 2024 · 7 comments
Open
1 task done

DOC: Docstrings missing from .py files in Sphinxext docs folder #58812

shindelr opened this issue May 22, 2024 · 7 comments
Labels

Comments

@shindelr
Copy link
Contributor

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://github.com/pandas-dev/pandas/blob/main/doc/sphinxext/contributors.py
https://github.com/pandas-dev/pandas/blob/main/doc/sphinxext/announce.py

Documentation problem

Both announce.py and contributors.py are missing the class and function docstrings encouraged by Pandas documentation. There are around 5 functions and 1 class that need documenting. Docstrings are always helpful for new users looking to contribute to the codebase.

Suggested fix for documentation

The docs have a detailed docstring how-to guide:
https://pandas.pydata.org/docs/dev/development/contributing_docstring.html

@shindelr shindelr added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels May 22, 2024
@Aloqeely
Copy link
Member

Thanks for the suggestion. Ideally, we would want to have docstrings for every function, but I think it's more beneficial to write docstrings for the public pandas methods over these internal scripts.

Feel free to submit a PR to add the docstrings, but we also have open issues for improving the public documentation (such as #58065), and would appreciate your help on these issues instead

@Aloqeely Aloqeely removed the Needs Triage Issue that has not been reviewed by a pandas team member label May 23, 2024
@42bismuth
Copy link

I'm new to open source but interested in tackling this issue! Happy to learn and contribute. Can I take this on?

@Aloqeely
Copy link
Member

Can I take this on?

Of course!

@anishfish2
Copy link
Contributor

anishfish2 commented May 27, 2024

Hi! New to open source and just wondering what the progress was on this issue?

@MrF1ow
Copy link

MrF1ow commented May 27, 2024

Hello, I was wondering if I could tackle this as well?

@Aloqeely
Copy link
Member

Hey @anishfish2 and @MrF1ow, thanks for the interest but there is already someone working on this issue. Happy to have your help on other issues with the Docs label though!

@sumwun1
Copy link

sumwun1 commented May 31, 2024

If someone's already working on it, can they assign the issue to themself? That would make it easier for the rest of us to find unassigned issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment