Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR: more informative error message on bool arith op failures #7015

Merged
merged 2 commits into from
May 14, 2014
Merged

ERR: more informative error message on bool arith op failures #7015

merged 2 commits into from
May 14, 2014

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 30, 2014

closes #7011

@cpcloud cpcloud added this to the 0.14.0 milestone Apr 30, 2014
@cpcloud cpcloud self-assigned this Apr 30, 2014
@jreback
Copy link
Contributor

jreback commented May 1, 2014

can you repush, to make it rebuild travis

@jreback
Copy link
Contributor

jreback commented May 1, 2014

also can you update the release note with this issue as well , #6762

@jreback
Copy link
Contributor

jreback commented May 1, 2014

maybe add to API changes as well on v0.14.0, and an example if you think its worth it

@jreback
Copy link
Contributor

jreback commented May 5, 2014

looks fine...

don't merge just yet...trying to fix the caching issue on master

@cpcloud
Copy link
Member Author

cpcloud commented May 5, 2014

sure no prob

@cpcloud
Copy link
Member Author

cpcloud commented May 5, 2014

anything i can do to help on that front?

@jreback
Copy link
Contributor

jreback commented May 5, 2014

all see
u can merge

@cpcloud
Copy link
Member Author

cpcloud commented May 5, 2014

@jreback all see? don't understand...still failing i think there's some floating point exception ... let me check it ou

@jreback
Copy link
Contributor

jreback commented May 5, 2014

meant all set when u r ready
caching fixed in master

@jreback
Copy link
Contributor

jreback commented May 6, 2014

hmm...can you rebase/repush...see if their error repeats

@cpcloud
Copy link
Member Author

cpcloud commented May 8, 2014

having some trouble repro-ing this. need a bit more time to track it down ... might have to spin up an ubuntu machine

@jreback
Copy link
Contributor

jreback commented May 10, 2014

hows this coming?

@cpcloud
Copy link
Member Author

cpcloud commented May 14, 2014

ahhh github search was useful: turned up #3819 :)

@cpcloud
Copy link
Member Author

cpcloud commented May 14, 2014

what's strange is that it can only be reproduced on python 3.2 modding by 0 works fine on my local python 2.7.6

@cpcloud
Copy link
Member Author

cpcloud commented May 14, 2014

@jreback i'm okay with leaving mod as is for now. let me check to see if my other addition to the ops module screwed anything else up ... i don't think so but better safe than sorry

@jreback
Copy link
Contributor

jreback commented May 14, 2014

3.2 runs numpy 1.6.2 iirc

@cpcloud
Copy link
Member Author

cpcloud commented May 14, 2014

yep this is fine ... the _combine_* handle the r* ops that i've given op_strs to.

@cpcloud
Copy link
Member Author

cpcloud commented May 14, 2014

these are also all hit in test_arith_flex_frame

@cpcloud
Copy link
Member Author

cpcloud commented May 14, 2014

@jreback any last words?

@jreback
Copy link
Contributor

jreback commented May 14, 2014

g2g

cpcloud added a commit that referenced this pull request May 14, 2014
ERR: more informative error message on bool arith op failures
@cpcloud cpcloud merged commit f7e995c into pandas-dev:master May 14, 2014
@cpcloud cpcloud deleted the bool-raises-on-exprs-err-msg branch May 14, 2014 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arithmetic operation between Series and bool fails
2 participants