Fix Xl(sx|wt)Writer always using date_format even if a datetime is supplied. #7075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
XlsxWriter
andXlwtWriter
implementations there is a minor bug resulting in thedatetime_format
being discarded (i.e. https://github.com/pydata/pandas/blob/master/pandas/io/excel.py#L662):Since
datetime.datetime
derives fromdatetime.date
the secondif
-clause in the will always trigger, leading to thenum_format_str
being overwritten by thedate_format
.