-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: test_encode in test_html #7927
Comments
looks like those farm animals are sorry i couldn't resist |
jokes aside not sure what's going on here let me take a look |
@jreback any reason why this doesn't currently fail? i can repro locally, but this failure isn't showing up on travis |
I think this is using a pretty recent bs4 (4.3.2), not testing on travis with that |
but that's not actually where the bug is. it happens because i don't check for bytes and str types in |
this line in the tests with open(f, 'rb') as fobj:
return self.read_html(fobj.read(), encoding=encoding, index_col=0) should pass in a elif isinstance(obj, string_types): should test |
@jreback don't worry about it i'll figure it out |
actually those tests aren't even being run on travis |
really, they don't appear to be skipped? |
i know it's strange ... i think there's an installation issue tho not sure |
i changed to |
i don't see why that should matter tho |
ok it turns out that does matter. when i install using the sdist method everything passes and when i run it using the test is run tho which is why this is strange |
@jreback any reason to use |
no idea |
oh duh this is totally a data path issue,
|
so after this let's try to wrap up the conda stuff, maybe wait a little longer to see if anyone replies to the py32 dropping |
what are you doing about the numpy master build? can you support that in conda? if not, maybe we leave the 3.2/numpy_master as is? |
can we use the pandas wheel server to build things? if so i can build a nightly conda package for numpy master ... 3.2 is another story and will take longer, because i have to build all the required packages for python 3.2 and i have to build python 3.2 itself |
i've almost got the python 3.2 dist ready 2 go, then i can start building the deps on that |
ok that's fine. but why not use have a |
could do that too |
i guess i was just trying to use one thing do it all, which turned out to be harder than i might've thought mostly bc of py32 |
I mean you could be specific about the requirements files (to avoid confusino)
and such |
then can leave numpy_master/3.2 alone (as sort of static cases) |
i see ok i'll do that |
yeh just have
|
@cpcloud not sure if this is something I did (or didn't do)
I was testing the index sub-class on 3.4 (may have appeared on travis too)
/mnt/home/jreback/venv/py3.4/index/pandas/io/tests/data/html_encoding/chinese_utf-16.html'
The text was updated successfully, but these errors were encountered: