Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: allow Panel.shift on items axis #9890

Merged
merged 1 commit into from
Apr 15, 2015
Merged

Conversation

mortada
Copy link
Contributor

@mortada mortada commented Apr 14, 2015

I'm not sure why Panel.shift currently raises with axis='items', while axis=0 works.

This PR enables axis='items' and also updates the docstring to show the parameter periods instead of the deprecated lags

@jreback
Copy link
Contributor

jreback commented Apr 14, 2015

looks fine. prob some leftover code :)

pls add a release note
if you don't see test for all axes, can you add them (to cover the bases).

@jreback jreback added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Apr 14, 2015
@jreback jreback added this to the 0.16.1 milestone Apr 14, 2015
@mortada
Copy link
Contributor Author

mortada commented Apr 14, 2015

  • added a release note
  • there were tests for major and minor, and I've added a test for items

@jreback
Copy link
Contributor

jreback commented Apr 14, 2015

aweseom. ping on green.

@mortada
Copy link
Contributor Author

mortada commented Apr 15, 2015

@jreback build is green now

shoyer added a commit that referenced this pull request Apr 15, 2015
ENH: allow Panel.shift on items axis
@shoyer shoyer merged commit 8cbb579 into pandas-dev:master Apr 15, 2015
@shoyer
Copy link
Member

shoyer commented Apr 15, 2015

Thanks @mortada !

@mortada mortada deleted the panel_shift branch April 15, 2015 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants