Add feature_indices_ attribute to mapper
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xes of self.features in the extracted array
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute indicatesthe mapping between input and ouptut variables (see added docs). I'd like someone to give +1 before merging. :) @asford ?
Differences with implementation in #54:
self.feature_widths_and calculating theself.feature_indices_property on the fly, here I storeself.feature_widths_directlyfitandtransformduring the mapperfit. Since there is no reliable way to calculate the feature weights before applying the full transform, I prefer to leave the attribute unavailable until then. I don't know if it would be interesting to turn the attribute into a property to be able to raise a custom informative exception when some tries to access the attribute before transformation.Thoughts?