Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onCancel isn't being called on iOS #2

Closed
diegocouto opened this issue May 15, 2017 · 4 comments
Closed

onCancel isn't being called on iOS #2

diegocouto opened this issue May 15, 2017 · 4 comments

Comments

@diegocouto
Copy link

Hi, guys!

First of all, congratulations for your great work! We've been using react-native-datepicker-dialog for a while without any problems.

Recently, we noticed that the onCancel handler works like a charm on Android, but it isn't being called on iOS.

Versions

  • react-native - 0.43.3
  • react-native-datepicker-dialog - 0.0.4
@pandiaraj44
Copy link
Owner

Hi, @diegocouto,

Thanks for using the library and reporting issues,

We will check it and let you know!

@rahulnair25283
Copy link

Hi,

I have run into the same issue. onCancel isn't being called from iOS.
I really like this library otherwise. It is really simple to use.

Versions:
react-native: v0.43.3
react-native-dialog-picker: v0.0.4

@rahulnair25283
Copy link

Hi,

I observed that in DatePickerDialog.ios.js, the cancel() function calls a cancel() function from this.props instead of calling the onCancel() function.

@pandiaraj44
Copy link
Owner

Hi @rahulnair25283, You are right we have missed that one. Thanks for your contribution and fixed it. We will move this bug fixes and and some of new features on android datepicker mode selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants