Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to add text field variables. #40

Closed
Shihyeon opened this issue Apr 15, 2024 · 8 comments · Fixed by #44
Closed

I want to add text field variables. #40

Shihyeon opened this issue Apr 15, 2024 · 8 comments · Fixed by #44
Labels
type: feature New feature or request
Milestone

Comments

@Shihyeon
Copy link

Replace this with a clear and concise description of the feature that you are requesting. If the feature is related to a problem, also describe the problem.

I want to add text field variables.

{app_version}: Version of the IDE
{app_edition}: Edition of the IDE
{module_name} or {directory_name}: Name of the current module(directory)
{file_size}: Size of the current file

@Shihyeon Shihyeon added the type: feature New feature or request label Apr 15, 2024
@pandier
Copy link
Owner

pandier commented Apr 16, 2024

{app_version} is easy enough to add.
Not sure how {app_edition} would work, because IDEs like WebStorm don't have an edition.
Not sure what you mean with {module_name}, a project can have multiple modules, do you mean the one that is currently being edited?
{file_size} may be harder to implement, but not impossible.

@Shihyeon
Copy link
Author

App edition refers to community edition and ultimate edition. If it is difficult to include it to maintain compatibility with other IDEs, I don't think it is necessary to include it.
{module_name} is the module currently being edited.
If {file_size} is difficult to implement, it is okay to not include it. This is what I want, but it is your right to produce and distribute it.
Thank you for making this open source plugin.

(The text may be strange because I used a translator.)

@pandier
Copy link
Owner

pandier commented Apr 17, 2024

Perhaps {app_full_name} could include the app name with the edition without the version:

  • {app_name} = IntelliJ IDEA
  • {app_full_name} = IntelliJ IDEA Community
  • {app_full_name} {app_version} = IntelliJ IDEA Community 2024.1

For apps that don't have an edition, {app_full_name} would include only the app name:

  • {app_name} = WebStorm
  • {app_full_name} = WebStorm

Also, what if no modules are currently being edited? Should the name be the project name? Could you maybe describe in detail how it would work so I can understand it better and implement it correctly?

@Shihyeon
Copy link
Author

Perhaps {app_full_name} could include the app name with the edition without the version:

{app_name} = IntelliJ IDEA
{app_full_name} = IntelliJ IDEA Community
{app_full_name} {app_version} = IntelliJ IDEA Community 2024.1
For apps that don't have an edition, {app_full_name} would include only the app name:

{app_name} = WebStorm
{app_full_name} = WebStorm

good

Also, what if no modules are currently being edited? Should the name be the project name? Could you maybe describe in detail how it would work so I can understand it better and implement it correctly?

Different from {project_name}. More precisely, I think the directory name would be more correct than the module name. The directory where the current file is located.

(I'm using a vscode extension that has a similar feel to this plugin. https://github.com/LeonardSSH/vscord)

@pandier
Copy link
Owner

pandier commented Apr 17, 2024

What about naming it {file_directory} or {file_directory_name} instead?
Which one do you think would be better?

@pandier pandier added this to the 1.1 milestone Apr 18, 2024
@Shihyeon
Copy link
Author

{file_directory} better then

@pandier pandier mentioned this issue Apr 19, 2024
4 tasks
@pandier pandier linked a pull request Apr 19, 2024 that will close this issue
4 tasks
@pandier pandier mentioned this issue Apr 19, 2024
4 tasks
@pandier pandier removed a link to a pull request Apr 19, 2024
4 tasks
@pandier pandier linked a pull request Apr 19, 2024 that will close this issue
4 tasks
@pandier
Copy link
Owner

pandier commented Apr 20, 2024

Since it was too complex to implement the {file_size} variable, I decided to split in into a different issue #48 for future implementation.

@pandier
Copy link
Owner

pandier commented Apr 20, 2024

The pull request has been merged and the variables will be avalible in the next 1.1 release.

@pandier pandier closed this as completed Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants