Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal intl test directory #260

Merged
merged 1 commit into from May 17, 2019
Merged

Add internal intl test directory #260

merged 1 commit into from May 17, 2019

Conversation

pmarkee
Copy link
Contributor

@pmarkee pmarkee commented May 16, 2019

Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu

fails += 1

if fails > 0:
raise Exception('ES2015 tests failed')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a typo. Please fix ES2015 to Intl.

Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu
@pmarkee
Copy link
Contributor Author

pmarkee commented May 17, 2019

@clover2123 Thanks, I corrected the typo.

Copy link
Contributor

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ksh8281 ksh8281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit a8d9fda into Samsung:master May 17, 2019
@pmarkee pmarkee deleted the intl-tests branch May 20, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants