-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hangglider protection message spamming #377
Comments
interesting 😕 |
I was able to replicate it on my test server; it only happens when in an area protected by a protection block, not for those protected by The spam is caused by this call to Not quite sure how to fix it though, other than adding a timer so that the message is sent less often, just to get rid of the spamming. |
I'm not sure about a solution either but IMO the chat message is a very weird side-effect for a function that should just check the protection... :/ Maybe a third parameter in EDIT: now that i think of it: the digtron has the same issues if you drive into protected areas if i remember correctly. This looks like a global issue... |
Upstream issue: https://notabug.org/TenPlus1/protector/issues/17 |
Using public workshop machines is also affected. |
I don't think flak is actually used much on this server, so maybe we could cut out hangglider init.lua lines 155 to 163 as a temporary solution while we wait for TenPlus1 to deal with the flaws in protector? |
I'd rather like to fix the |
But okay |
Removed "waiting" label as this can be now fixed at https://github.com/S-S-X/protector repo and can try to merge stuff to upstream later. |
@tenplus1 is aware of the issue by the way: https://notabug.org/TenPlus1/protector/issues/19 I hope we can merge that upstream again some day... |
@S-S-X i created a PR with your commits for the protector-tool registration: https://notabug.org/TenPlus1/protector/pulls/20 Let's see if/how 10+1 responds... |
When flying through an area, without flak, owned by another player, the chat is spammed with messages.
I have failed to reproduce on my test-server. Only see this on pandorabox.io
The text was updated successfully, but these errors were encountered: