Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show /news on logon depending on XP #410

Closed
SwissalpS opened this issue Jan 12, 2020 · 7 comments
Closed

show /news on logon depending on XP #410

SwissalpS opened this issue Jan 12, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@SwissalpS
Copy link
Contributor

First time I logged on, I read it. About the fifth time I read it again. After that I only read it after I invoke /news, never when logging on.

Do others also feel it could be dropped for users that frequently log on?
I suggest only showing it to users bellow a certain low XP amount.

@OgelGames
Copy link
Contributor

I look at it briefly to see if there's anything new, but otherwise I don't read it, but if it was never shown, I would never remember to look at it... 😄
Maybe there could be a toggle for it, just like for the XP hud, so players could choose if they want to see it?

@OgelGames OgelGames added In-Game enhancement New feature or request and removed In-Game labels Jan 13, 2020
@thomasrudin
Copy link

The original idea was to put actual news in there, looks like this
is just a welcome banner now, so the xp-limit works for me...

@SwissalpS
Copy link
Contributor Author

SwissalpS commented Jan 20, 2020

server_news mod has a priv already setup: news_bypass
so it would only need to be another priv one gets when passing certain XP amount.

Edit: added it for now

Edit2: would be nice if it was based on changes to news.txt file. So you could actually present news when it's new.

@OgelGames
Copy link
Contributor

OgelGames commented Jan 21, 2020

server_news mod has a priv already setup: news_bypass
so it would only need to be another priv one gets when passing certain XP amount.

Yes, but that always stops the news from being shown: https://github.com/Ezhh/server_news/blob/master/init.lua#L24
I guess it's an okay solution for now though...

would be nice if it was based on changes to news.txt file. So you could actually present news when it's new.

That would be the best solution, but I'm not sure how it would work without keeping a record of what each player has seen and comparing it to the current news.

@thomasrudin
Copy link

i removed the server_news mod until a better solution and actual news-content comes along 😄

@thomasrudin
Copy link

@SwissalpS sorry, i just saw your edit after pulling: pandorabox-io/pandorabox_custom@ed9c948 😖

is it ok if we leave the server_news disabled until there is a news-concept or something alike...?

@SwissalpS
Copy link
Contributor Author

@thomasrudin I'm fine with that.
@OgelGames yes, that was the point, to hide news for players who know about /news.
Mostly, when logging on, it's not what players care about. Especially if there was a crash while they were gliding.

500 XP may be rather low, maybe a threshold at stone level would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants