Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node breakers smelting everything even without lava tools #513

Closed
S-S-X opened this issue May 22, 2020 · 3 comments
Closed

Node breakers smelting everything even without lava tools #513

S-S-X opened this issue May 22, 2020 · 3 comments
Labels
bug 🐛 Something isn't working Fixed Issue has been fixed/resolved but is waiting for something or needs testing

Comments

@S-S-X
Copy link
Member

S-S-X commented May 22, 2020 •
edited
Loading

Problem seems to be in last lavastuff commit and at line:
minetest-mods/lavastuff@7b405a4#diff-d7d74284e2e39f6c06d199c8e2bedbd0R71

Pipeworks fake player is not userdata but table: https://gitlab.com/OgelGames/pipeworks/-/blob/master/common.lua#L177

IMO problem is in lavastuff mod and should be fixed there, lavastuff should not assume that digger is always userdata type.
@S-S-X S-S-X added the bug 🐛 Something isn't working label May 22, 2020
@S-S-X
Copy link
Member Author

S-S-X commented May 22, 2020 •
edited
Loading

Issue should be fixed now minetest-mods/lavastuff@ff314c7

Test after pulled to mods repo and close when fix verified.

@S-S-X S-S-X added the Fixed Issue has been fixed/resolved but is waiting for something or needs testing label May 22, 2020
@OgelGames
Copy link
Contributor

Nice find, I looked at lavastuff, but I didn't notice that 👍

Still confused why it cooked saplings twice though...

@BuckarooBanzay
Copy link
Contributor

Nice work @S-S-X 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working Fixed Issue has been fixed/resolved but is waiting for something or needs testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BuckarooBanzay @OgelGames @S-S-X