Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Remove separate jQuery instance #6

Open
4 tasks
mwaddell opened this issue Oct 12, 2021 · 0 comments
Open
4 tasks

Remove separate jQuery instance #6

mwaddell opened this issue Oct 12, 2021 · 0 comments

Comments

@mwaddell
Copy link
Member

mwaddell commented Oct 12, 2021

Currently, redmine-stuff-to-do-plugin bundles it's own versions of jquery, jqueryUI and jquery.contextMenu which are incompatible with the versions deployed as part of Redmine 4.2.1. It also includes "Facebox" which is dependent upon jquery 1.x and is no longer supported.

This task involves the following:

  • Removing the dependencies jquery, jqueryUI, jquery.contextMenu and facebox
  • Replace the use of facebox with dialog from jqueryUI to display a modal popup
  • Replace the use of jquery.contextMenu to use Redmine 4.2.1's existing contextMenu handler
  • Update any code which is incompatible with jquery 3.5.1
    • For example, the use of on("ajax:complete" and on("ajax:beforeSend" in
      function () {
      $("a.gridsubmit")
      /* ajax:success sometimes not called */
      .on("ajax:complete", function (evt, data, status, xhr) {
      console.log(data.statusText);
      if (data.statusText == "OK") {
      $("#time-grid").html(data.responseText);
      }
      });
      $("#time_grid_button_submit")
      .on("ajax:beforeSend", function (evt, data, status, xhr) {
      status.url = status.url.replace(/time_grid.*\?.*/, 'time_grid?' + $("#query_form").serialize());
      console.log(status.url);
      });
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant