Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_perfect_model_prediction takes a while to run #122

Closed
ahuang11 opened this issue May 11, 2019 · 5 comments · Fixed by #232
Closed

test_perfect_model_prediction takes a while to run #122

ahuang11 opened this issue May 11, 2019 · 5 comments · Fixed by #232

Comments

@ahuang11
Copy link
Member

I haven't looked into it; but maybe could drop redundant tests or optimize the function it's testing.

@aaronspring
Copy link
Collaborator

agree. the 3D tests takes really long. maybe we test all in 1D and just a few selected metrics in 3D. or just subselect 3x3 grids

@bradyrx
Copy link
Collaborator

bradyrx commented May 13, 2019

We're already subselecting a small grid in 3D in test_perfect_model_prediction. I imagine a lot of the time is spent on loading in the datasets too? Maybe we just create 3D dummy data here..

@ahuang11
Copy link
Member Author

When I have time I'll try profiling the code and try to optimize it

@aaronspring
Copy link
Collaborator

when subselecting 3D we should maybe use xr.open_mfdataset or xr.open_dataset(files, chunks={}) to only load the subselected data?

@aaronspring
Copy link
Collaborator

probably we dont have to test whether all metrics pass the bootstrap function, but rather testing one metric for all different setups and once testing all metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants