Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release of Climpred ? #839

Closed
Zeitsperre opened this issue Nov 8, 2023 · 9 comments · Fixed by #841
Closed

New release of Climpred ? #839

Zeitsperre opened this issue Nov 8, 2023 · 9 comments · Fixed by #841

Comments

@Zeitsperre
Copy link
Collaborator

I'm excited to see how much more stable the latest main branch of climpred is in my downstream projects. Are we ready to put out a new release?

@aaronspring
Copy link
Collaborator

All ready from my point of view

@Zeitsperre
Copy link
Collaborator Author

Awesome! I don't have the privileges to make releases on GitHub, but if that's extended to me, I can take over.

If we want, I could even adapt a workflow from another project to make semi-automatic deployments to PyPI/TestPyPI. I'll open a PR for that!

@aaronspring
Copy link
Collaborator

There is even a GHA workflow for this but I doubt it actually works

@aaronspring
Copy link
Collaborator

Maintainer rights given

@Zeitsperre
Copy link
Collaborator Author

There is even a GHA workflow for this but I doubt it actually works

I see it. Yeah, I've recently been adopting Trusted Publishing so that we don't need to supply usernames and passwords. Much better for collaborative projects.

@Zeitsperre
Copy link
Collaborator Author

@aaronspring I'm nearly done my update. It's just missing one final step:

Would you be able to add the following configurations to the repo?

  • Settings → Environments → "New environment" → "staging"
  • Settings → Environments → "New environment" → "production"

For both:

  • Enable "Required reviewers" and add everyone who is allowed to make releases
  • Enable "Prevent self-review"
  • Enable "Allow administrators to bypass configured protection rules" (so that you don't have to wait on me if you're preparing a release)

This will give us a few security checks before anything is sent out to TestPyPI and PyPI. You'll be free to remove the PYPI_USERNAME and PYPI_PASSWORD secrets afterwards.

@aaronspring
Copy link
Collaborator

Both envs added. Thanks for leading this

@Zeitsperre
Copy link
Collaborator Author

Ah, two final things:

  1. For Trusted Publishing, you need to configure the Climpred PyPI with the following:
  • Your Account → climpred → "Publishing" → Below "Add a new publisher":
    • Owner: "pangeo-data"
    • Repository name: "climpred"
    • Workflow name: "publish-production-pypi.yml"
    • Environment name: "production"
  1. I've made an account for climpred on TestPyPI (https://test.pypi.org/project/climpred/). If you make an account there, I'll pass maintainer status onto you.

That should be the end of the configurations required!

@aaronspring
Copy link
Collaborator

  1. done
  2. no need

@Zeitsperre Zeitsperre mentioned this issue Nov 9, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants