Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test against xarray main branch #37

Closed
dcherian opened this issue Oct 2, 2020 · 2 comments · Fixed by #48
Closed

test against xarray main branch #37

dcherian opened this issue Oct 2, 2020 · 2 comments · Fixed by #48

Comments

@dcherian
Copy link
Contributor

dcherian commented Oct 2, 2020

This would be good to catch things like #36 before releasing a new xarray version.

See https://github.com/xgcm/xgcm/blob/b2fc97e29c6e262f69dc699d4c31dd2ad3ee53fc/.github/workflows/ci.yaml#L86-L114 for an example wiht github workflows.
@raphaeldussin
Copy link
Contributor

any volunteer for this? wink to @andersy005

@andersy005
Copy link
Member

any volunteer for this? wink to @andersy005

This is straightforward to do :) Expect a PR from me soon

@andersy005 andersy005 mentioned this issue Nov 17, 2020
Merged
@Plantain Plantain mentioned this issue Apr 22, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test against upstream dependencies + nightly CI andersy005/xESMF
3 participants
@dcherian @andersy005 @raphaeldussin