Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Lint for variable scoping serialization issue? (Or just fix it?) #202

Closed
cisaacstern opened this issue Dec 16, 2022 · 0 comments
Closed

Comments

@cisaacstern
Copy link
Member

By far the most common Dataflow bug we are seeing on staged-recipes is the serialization issue where module-level names are not available within function scopes. A few examples from the last 24 hrs:

Maybe we need a custom linter to flag this before we /run the tests?

Even better would be to fix it, if possible. I believe the Beam option save_main_session (which we use) is supposed to address this, but it doesn't appear to work, and some knowledgable folks at the Beam Summit I attended in Austin last July told me this was always a "hacky workaround". If I remember correctly, I was told using a setup.py as described in the Beam docs here might possibly resolve this. I'll do an experiment to see if that's the case.

@cisaacstern cisaacstern changed the title Linter variable scoping serialization issue? (Or just fix it?) Lint for variable scoping serialization issue? (Or just fix it?) Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant