Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCM API has been deprecated for removal June 2024 #32

Open
chris13524 opened this issue Sep 27, 2023 · 13 comments
Open

FCM API has been deprecated for removal June 2024 #32

chris13524 opened this issue Sep 27, 2023 · 13 comments

Comments

@chris13524
Copy link

chris13524 commented Sep 27, 2023

The API endpoint being used has been deprecated and will be removed in June 2024.

@chris13524 chris13524 changed the title FCM API has been deprecated FCM API has been deprecated for removal June 2024 Sep 27, 2023
@adnanjpg
Copy link

adnanjpg commented Nov 1, 2023

hey, I've recently worked on implementing fcm calls on my rust app, and was able to achieve connecting to the new auth api using the gauth crate. I can open a pr which implements that.

@panicbit @pimeys

@eloff
Copy link

eloff commented Dec 8, 2023

@panicbit this needs to be addressed, but I think you've got too much on your plate. This library hasn't been updated in a year. I'd be happy to take over maintenance, can we discuss that? We need this library at my company. You can reach me here and privately at dan [at] upduo.com

@rj76
Copy link

rj76 commented Dec 21, 2023

@adnanjpg Could you perhaps already create that PR, or share some code which implements this?

@adnanjpg
Copy link

adnanjpg commented Dec 21, 2023

@rj76 sure, I'll share an example code here by the weekend, opening a pr will take a while though as im a bit busy these few weeks

@rj76
Copy link

rj76 commented Dec 21, 2023

@adnanjpg thank you so much :) maybe I can put together a PR if time allows

@adnanjpg
Copy link

@rj76 here you go. please follow the instructions written in the .env file and fill in a device id that you want the notification sent to in main.rs

@adnanjpg
Copy link

@eloff I think it's best for you to open an issue about taking over the maintenance, if there's still no response then you can invite contributors to your fork

@rj76
Copy link

rj76 commented Dec 29, 2023

@eloff thanks to @adnanjpg the client change that uses gauth-rs is already finished, but still needs some love and testing. I'll post the link to the fork here when done.

@adnanjpg
Copy link

@rj76 hi, i had been working on this for the past hour and i was about to finish too, seems like we should've coordinated better

anyway, assuming you've made more progress on this than i have, im going to pause my work and wait for you

if you need any help, please don't hesitate to mention me

@rj76
Copy link

rj76 commented Dec 30, 2023

@adnanjpg Would you like to review and possibly test?

https://github.com/rj76/fcm-rust

@adnanjpg
Copy link

@rj76 hi, the work you've done looks fantastic, there's just some tiny mistakes & refactors, and also there's some errors. I will be opening a pr on your repo with the fixes I've put & open issues with the concerns I have

@rj76
Copy link

rj76 commented Dec 31, 2023

if everything was good i made i would be worried 😁 thanks in advance for your time and feedback

@adnanjpg
Copy link

@rj76 hi, in case you have not noticed I had submitted a pr yesterday on your repo. happy new year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants