Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add PHP 7.3 support? #17

Closed
za3k opened this issue Apr 21, 2022 · 2 comments · Fixed by #19
Closed

Re-add PHP 7.3 support? #17

za3k opened this issue Apr 21, 2022 · 2 comments · Fixed by #19

Comments

@za3k
Copy link
Contributor

za3k commented Apr 21, 2022

You just updated the markdown libraries to add PHP 8 support. Unfortunately, this broke PHP 7.3 support. PHP 7.3 is the latest available in debian buster (one version ago, which I'm running), though 7.4 is available in the latest stable. The problems introduced were:

  • public string, protected int etc are not available in 7.3. Many instances
  • One => lambda function was added

readme.txt still says this supports PHP 4. Could you update the docs or fix the problem? Happy to provide a PR if you're okay patching the library as a solution, which is what I did.

@za3k
Copy link
Contributor Author

za3k commented Apr 21, 2022

Whoops, may have spoken too early. I'm actually seeing a number of issues with my install, even with these changes. Viewing every page shows the same thing, and every page edits to the same thing.

Edit: It was a bug with PATH_INFO not being set with my nginx config for links like https://lexicon.za3k.com/index.php/RulesOfLexicon. Disregard this comment.

@panicsteve
Copy link
Owner

Thank you for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants