[3.0] Improve code quality with high-end services

[sopitz]

What about using codacy (https://www.codacy.com/) to improve and maintain code quality? It's free for OSS (which should apply to this project). I would support using a tool/that tool.

[GrahamCampbell]

https://scrutinizer-ci.com/ is also very good.

[sopitz]

@panique what do you think? Should we just try one or both of the services to see if its useful?

[ScheerMT]

Have you guys used a tool like this @sopitz and @GrahamCampbell ? If so, have the metrics they provided been useful to the development? That seems like a very small part of it and being able to standardize other aspects of the code seem to be of more benefit to projects... Am I right? Really haven't had a chance to work on larger projects that would benefit from this personally

[sopitz]

Yes @ScheerMT. I'm currently working in a project that does CI at a very high level and I can definitely recommend it. Especially with upcoming unit testing.
It can be a pain in the ass if the confit is ugly and you need to care more about code quality then about implementing features, but done right it really adds value in maintaining a project.

[panique]

@ALL: Thanks, I definitly cannot say anything about these services as I don't have experience with them, but writing high-end code is a very good goal for 3.0 (especially as this project has become so popular) ! As long as the code and the structure stays human-readable and doesn't add complexity etc. ...

[sopitz]

Btw: have a look into codeship (https://www.codeship.io) as well. You get free CI + Conituous Deployment for free! This would work together with the plan of unit-testing the whole application and having the demo on the most up-to-date version.

[jaimefjorge]

Hi!

I'm Jaime and I run Codacy. Sorry to drop by your conversation.

I just installed PHP-Login in Codacy so you can check how it looks:
https://www.codacy.com/public/panique/phplogin/dashboard

I also added you as collaborators for you to completely try the product.

Anything you need, just tell me. We'll build it.

[panique]

Thanks, will have a look!

[atdotslashdot]

....The method splitUrl() has an NPath complexity of 3126. The configured NPath complexity threshold is 200.

Sorry, but it doesn't look that complex to me.

[panique]

Let's do this with the 3.0 version.
I also like the SensioLabs tool (https://insight.sensiolabs.com/).

[panique]

Thanks gentlemen, I've created a sticky ticket for that:
[STICKY] Public code quality analyzer links