Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: io_uring support #608

Closed
sprappcom opened this issue May 31, 2024 · 6 comments
Closed

[Feature]: io_uring support #608

sprappcom opened this issue May 31, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request proposal Proposal for this repo
Milestone

Comments

@sprappcom
Copy link

Description of new feature

io uring is really much faster. hope gnet can port it asap too.

Scenarios for new feature

performance

Breaking changes or not?

No

Code snippets (optional)

No response

Alternatives for new feature

None.

Additional context (optional)

None.

@sprappcom sprappcom added enhancement New feature or request proposal Proposal for this repo labels May 31, 2024
@panjf2000
Copy link
Owner

io_uring support is on our roadmap. It may be implemented someday, but there is no specific guarantee for that.

epoll should suffice to support the most cases, thus io_uring shouldn't be so pressing at this point. Are you experiencing some performance bottlenecks currently?

@panjf2000 panjf2000 changed the title [Feature]: now tls is possible, when can we have io_uring? [Feature]: io_uring support Jun 2, 2024
@panjf2000 panjf2000 added this to the Long term milestone Jun 2, 2024
@sprappcom
Copy link
Author

sprappcom commented Jun 16, 2024

@panjf2000 sry for late reply.
my only perf bottleneck is without io_uring.

this benchmark is like an eyesore, it makes my gnet implementation looks terrible.
https://github.com/y001j/uringnet

i'm only looking at gnet once in a while to solve 2 issues:

  1. io_uring
  2. http2 integration / cloudwego/hertz replacement to netpoll

gnet is one of the best work for golang. need io_uring to complete it.

well done and thx. cant thank u enough.

p.s : 1 last thing, hope u can reduce heap obj for gnet after io_uring is done.

@sprappcom
Copy link
Author

@panjf2000 can u pls help with standardizing the example for use with tls? it's already there but there doesnt seem to have support or example on how to use it.

please support it with examples for https / tcp connection:

https://github.com/gnet-io/tls

can u take a look into this? i'm trying to upgrade redhub to use v2 and tls:

https://github.com/sprappcom/redhub/blob/main/redhub.go

@panjf2000
Copy link
Owner

I think #565 is still WIP.

@panjf2000
Copy link
Owner

Duplicate issue, move to #327

@gh-translator
Copy link
Collaborator

🤖 Non-English text detected, translating...


Duplicate issue, move to #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal Proposal for this repo
Projects
None yet
Development

No branches or pull requests

3 participants