Allow more flexibility in how serializers are resolved when strings are passed to the serializer option #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all serializers are named the same as the association. If a serializer string is passed to the has_one or has_many association, we can look up the serializer name directly, instead of appending Serializer to the association name.
yosiat
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows has_one and has_many associations to use a different serializer than the association name, if a string is passed in for the serializer.
Using a real world example - If you have this defined:
has_one :current_driver, serializer: "User"in a Vehicle, the serializer resolver will always look forCurrentDriverSerializer, which is not the correct serializer, because we wanted aUserSerializer.