Keep alias_name when method_added (#135) #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`method_added` removes the same name attribute from `attributes` and add a new one to `method_fields`. It ignores `alias_name` of the original attribute. Then the alias setting does not work with method fields. With this patch, the original `alias_name` is kept. In addition, `serialize_method_fields` does not use `attr_name_for_serialization` unlike other serialize functions. This patch also fixes it to use the function.
yosiat
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method_addedremoves the same name attribute fromattributesand add a new one tomethod_fields. It ignoresalias_nameof the original attribute.Then the alias setting does not work with method fields.
With this patch, the original
alias_nameis kept.In addition,
serialize_method_fieldsdoes not useattr_name_for_serializationunlike other serialize functions. This patch also fixes it to use the function.