Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal props are not passed through #37

Closed
ashish-kale opened this issue Oct 10, 2019 · 6 comments
Closed

Modal props are not passed through #37

ashish-kale opened this issue Oct 10, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@ashish-kale
Copy link
Contributor

ashish-kale commented Oct 10, 2019

When device orientation is changed on iOS, the modal remains in the old orientation
Modal props override can solve the issue using supportedOrientations prop of ModalProps

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Oct 10, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.72. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@ashish-kale
Copy link
Contributor Author

@kozmonotselcuk @biskuvit Can you please check and merge and release new version for this?

@omeraplak
Copy link
Contributor

Hi @ashish-kale ,
we’ve launched 1.2.7 version on NPM. Feel free to contact us if you need anything.

@ashish-kale
Copy link
Contributor Author

@omeraplak I checked the 1.2.7 version, the package has my new source code, but the dist folder has old code. Can you please check?

@ashish-kale
Copy link
Contributor Author

@omeraplak created #39 to build the included changes.Can you please release this?

@omeraplak
Copy link
Contributor

Hi @ashish-kale ,
we’ve launched 1.2.8 version on NPM. Feel free to contact us if you need anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants