wp config simplifed to avoid complications on non live envs #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzsequence
requested changes
May 11, 2023
pantheon.php
Outdated
| @@ -45,6 +42,9 @@ | |||
| if ( getenv( 'FRAMEWORK' ) === 'wordpress_network' && ! defined( 'WP_ALLOW_MULTISITE' ) ) { | |||
| define( 'WP_ALLOW_MULTISITE', true ); | |||
| } | |||
| if ( defined( 'MULTISITE' ) && defined( 'WP_ALLOW_MULTISITE' ) && WP_ALLOW_MULTISITE ) { | |||
| require_once 'inc/pantheon-network-setup.php'; | |||
| } | |||
There was a problem hiding this comment.
These lines are unrelated and merged in #21. Can you remove these from the PR?
There was a problem hiding this comment.
Thanks for the review. merged with the latest branch
inc/network/includes-network.php
Outdated
| define( 'MULTISITE', true ); | ||
| define( 'SUBDOMAIN_INSTALL', <?php echo $subdomain_install ? 'true' : 'false'; ?> ); | ||
| define( 'DOMAIN_CURRENT_SITE', $hostname ); | ||
| define( 'DOMAIN_CURRENT_SITE', $_SERVER['HTTP_HOST'] ); |
There was a problem hiding this comment.
Have you tested with Lando to confirm dropping the hard-coded hostname doesn't break anything locally?
There was a problem hiding this comment.
Tested with Lando and found issues:
- Getting a PHP Notice when running
lando wpcli commands:PHP Notice: Undefined index: HTTP_HOST in phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(1296) : eval()'d code on line 90 - When pulling a WPMS site, users need to do a
lando wp search-replacewith--all-tablesflag to include thewp_blogs&wp_siteentries to be updated
Updated my PR to to fix the 1
For the 2 error, we might need to add a more verbose error to the generic error Error establishing a database connection to make sure that all the URLs are replaced accordingly
jazzsequence
added
the
needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16