Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite PHPUnit tests to test with constants set/unset #32

Open
jazzsequence opened this issue Feb 14, 2024 · 0 comments
Open

Rewrite PHPUnit tests to test with constants set/unset #32

jazzsequence opened this issue Feb 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jazzsequence
Copy link
Contributor

This is a vanity test that doesn't actually test anything that is failing. It was added to test against #30 when the DISABLE_PANTHEON_UPDATE_NOTICES constant is set to true except that at the time the tests are run, it's set to false and the pantheon-updates.php file is loaded. Basically, all the pantheon-updates tests should be inside a separate test group that is only run when the constant is false and separated from other tests when the constant is true. There are likely other constants that perform similar functions and would require similar grouping.

@jazzsequence jazzsequence added the enhancement New feature or request label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant