Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the region when creating a site #225

Merged
merged 4 commits into from Aug 19, 2019

Conversation

erichomanchuk
Copy link
Contributor

@erichomanchuk erichomanchuk commented Jul 17, 2019

With the new region options available in Pantheon. I needed to start creating my sites in the CA region and so I needed this plugin to allow passing the option --region to the terminus site:create command.


This change is Reviewable

@ataylorme
Copy link
Contributor

@erichomanchuk thanks for the PR! I'll get this tested/reviewed

@ataylorme
Copy link
Contributor

@greg-1-anderson any objection to this? I tested and it is working well.

@rvtraveller
Copy link
Collaborator

+1 from me as well. I used it for creation of bt-lambda-test-072019-* projects and it worked beautifully.

Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the enhancement!

@ataylorme ataylorme merged commit 5750782 into pantheon-systems:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants