New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --pr-only option to build:env:create and build:env:push #91
Comments
CircleCI already has it's own option for only building on pull request. I think Travis does too. So this option would be for the usecase of a team that wants unit tests/code sniffing even if there isn't a pull request but not deploys to Pantheon? |
@stevector that's correct. This idea is that developers can create a branch and push to GitHub as they have commits, even if it's not ready for review by others. At this point code sniffing and unit tests would run. If those fail the code can be refactored. This should be a quick, iterative process and deploying to Pantheon and running Behat each time will slow things down when work isn't ready to be reviewed anyway. Once the work is complete and ready for review by others a pull request is created. At that point a code review on GitHub can commence and a multidev on Pantheon is created and linked in the pull request for review of the changes in a fully built site. Behat tests can also run at this point. The multidev environments on Pantheon are also named See these comments for further discussion as well. |
Wouldn't it be better to have a |
Closing in favor of #118 |
Example WordPress Composer is only creating multidevs environments on Pantheon when a pull request is created. See this comment thread for reasoning.
There is logic in Example WordPress Composer to determine if a deployment to Pantheon should happen (e.g. is the build a pull request). Ideally this logic can live in the Terminus build tools plugin behind a
--pr-only
option forbuild:env:create
andbuild:env:push
The text was updated successfully, but these errors were encountered: