Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow script to continue when merge conflict (or other error) discovered #4

Open
SteveRyan-ASU opened this issue Feb 3, 2017 · 2 comments

Comments

@SteveRyan-ASU
Copy link

When running the following command, the mass-update plugin executes as intended, and works well.
terminus site:list --format=list | terminus site:mass-update:apply

But upon attempting to apply an update where the site has a merge conflict present, the script terminates upon receiving that error.

2017-02-03_09-41-15

Potential solutions

  • Allow script to continue executing the remaining items in the queue. Either by default or via another option within the plugin.
  • Allow for the --dry-run option to test for merge conflicts prior to actually executing the script ahead of time.

Thanks for all that you do! :-)

@nstielau
Copy link

nstielau commented Feb 3, 2017

Good ideas, @SteveRyan-ASU. Testing for merge conflicts conflicts doesn't seem as useful to me as something like a --continue-on-failure flag, and possible spitting out which sites errored at the end.

@SteveRyan-ASU
Copy link
Author

Agreed about the approach as well. That would also allow the script to continue if it encountered other errors along the way as well. Example: trying to mass-update update a site that was still in SFTP mode would probably also result in the script stopping execution. (Untested.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants